MOI 0.10 upgrade#105
Merged
mtanneau merged 3 commits intods4dm:masterfrom Nov 14, 2021
Merged
Conversation
Contributor
Author
|
Also closes #103, MOI 0.9 and 0.10 will not be compatible |
Contributor
Author
|
As a follow-up to this, the MOI tests could also be run with the numeric types supported b Tulip |
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 90.64% 88.66% -1.98%
==========================================
Files 43 43
Lines 2725 2718 -7
==========================================
- Hits 2470 2410 -60
- Misses 255 308 +53
Continue to review full report at Codecov.
|
Contributor
Author
|
bump @mtanneau |
mtanneau
approved these changes
Nov 14, 2021
Member
mtanneau
left a comment
mtanneau
left a comment
There was a problem hiding this comment.
Good to go! Sorry for the delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades Tulip to MOI 0.10
There are some minor issues to fix for the tests but not that many.
The blocker left for this PR is Convex.jl used in the tests and still locked on MOI 0.9